Bug 136971

Summary: Crash in: swlo.dll while using Basic macro to delete a character while cursor is in a textbox
Product: LibreOffice Reporter: sdc.blanco
Component: WriterAssignee: Not Assigned <libreoffice-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: 79045_79045, andreas.heinisch, aron.budea, mattkse, mikekaganski, serval2412, stephane.guillou, xiscofauli
Priority: medium Keywords: haveBacktrace
Version: Inherited From OOo   
Hardware: All   
OS: All   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=132810
Whiteboard: target:24.8.0 target:24.2.1 target:7.6.5
Crash report or crash signature: ["swlo.dll"] Regression By:
Bug Depends on:    
Bug Blocks: 103494, 107659, 133092    
Attachments: Test document with steps to reproduce crash
bt with debug symbols

Description sdc.blanco 2020-09-23 09:34:59 UTC 
Created attachment 165790 [details]
Test document with steps to reproduce crash

This bug was filed from the crash reporting server and is br-4cec9caf-8105-4ebc-9388-e0980519b5c3.
=========================================

1.  Use Basic macro (in test document).

2.  Assign that macro to a key  (I used Ctrl-K)

3.  Use assigned key in text document, no problem.

4.  Use assigned key in a textbox  (example given in text document), reproducible crash.


This crash report was produced with:
Version: 7.0.0.0.beta2 (x64)
Build ID: 1c213561a365b5666167321de68c9977500c9612
CPU threads: 8; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win
Locale: da-DK (en_DK); UI: en-US
Calc: threaded
Comment 1 Julien Nabet 2020-09-23 19:21:40 UTC 
Created attachment 165801 [details]
bt with debug symbols

On pc Debian x86-64 with master sources updated today, I could reproduce this.
Comment 2 Xisco Faulí 2020-09-25 14:38:51 UTC 
For the record, the cursor must be inside the textbox
Comment 3 Xisco Faulí 2020-09-25 14:45:32 UTC 
Also reproduced in

Version: 5.2.0.0.alpha0+
Build ID: 3ca42d8d51174010d5e8a32b96e9b4c0b3730a53
Threads 4; Ver: 5.7; Render: default; 

Locale: en-US (en_US.UTF-8)
Comment 4 Xisco Faulí 2020-09-25 16:51:03 UTC 
Also reproduced in

Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a)
Comment 5 QA Administrators 2022-09-26 03:30:13 UTC Comment hidden (obsolete)
Comment 6 Roman Kuznetsov 2022-10-02 17:58:00 UTC 
Still repro in

Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 48b9cbc742de3f6120986cb6cafc92eb5009da82
CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: threaded

Andreas, Mike, possibly you will be interesting with it
Comment 7 Andreas Heinisch 2022-10-03 07:26:25 UTC 
LO does not crash if the macro will be executed directly in the basic editor.
Comment 8 Roman Kuznetsov 2022-10-03 07:38:52 UTC 
(In reply to Andreas Heinisch from comment #7)
> LO does not crash if the macro will be executed directly in the basic editor.

I tried to start macro from main menu, crash still repro
Comment 9 Andreas Heinisch 2022-10-03 08:03:43 UTC 
In the main menu it indeed crashes too.
Comment 10 Stéphane Guillou (stragu) 2024-05-02 02:22:09 UTC 
Reproduced in OOo 3.3 and LO 7.5.9.

Not reproduced anymore in:

Version: 24.2.2.2 (X86_64) / LibreOffice Community
Build ID: d56cc158d8a96260b836f100ef4b4ef25d6f1a01
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

Bibisect fix with linux-64-24.2 to first good build [b497d3d200aad6a5946b4d5fcc50742b71521fc3] which points to a72dad4e4c0d41b61e453919401fcefc8e5e9b43 which is a cherrypick of:

   commit 19062c98da5b2e9edc7a99068fa06a83c7578826
   author	Matt K 	Thu Jan 11 20:37:01 2024 -0600
   committer	Mike Kaganski 	Sat Jan 13 18:21:02 2024 +0100
   tdf#132810 Prevent crashes with gallery objects
   Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161950

Thanks Matt!